problem patching

[chrisjs162216]

Originally Posted by Ronoh55

YAY new problems!

This is after removing comment marks

Not sure about the warnings and syntax error, but it seems like you have the bmp resize patch, but didn't change the custom splash screen patch to reflect the changes by the bmp resize patch. Open up apps/misc.c and search for read_bmp_file - there should be a few commented lines under it that need to be uncommented. There should be 'directions' around that area in the file, inside the comments.

[disorganizer]

i suppose you have to replace

FORMAT_NATIVE | FORMAT_DITHER

with

FORMAT_NATIVE | FORMAT_DITHER, LCD_WIDTH, LCD_HEIGHT, BMP_RESIZE_DECREASE

in both occurrences of read_bmp_file.
just removing the comment-indicators in not enough imho.

can something other than BMP_RESIZE_DECREASE be used?

EDIT:
but atm i compiled revision 16158 with the following patches:
albumart-resize
custom_splash 7.1.5
multifont
pp5020-test-01
viewports-wps
viewports-lists

and all seems to compile and work well. just that bmp resize only support aa up to 175 in width (didnt check height).
with the s-parameter is resizes (increase and decrease in size), but most wps use only d (which only decreases size, but does not increas smaller aa).
the reason for this is that s is not supported by the svn aa implementation (yet), so wps using s will not be compatible with a svn build.

obviously newer bmp-resize versions are compatible to this patch without manual editing?

[Ronoh55]

I am hoping that the most recent version of the patch is compatible with the splash patch, I haven't tried patching again since I downloaded the new AA patch...I guess I should try now then shouldn't I?