android
  #1  
Old 10-31-2007, 05:44 PM
bacon_fat bacon_fat is offline
Junior Member
 
Join Date: Oct 2007
Posts: 11
Default FS#5047 - Extended BackLight Control

Hi folks,

Just wondering if any of the custom builders have any intention of ever including the above mentionned patch. I'm surprised it's not a more popular feature, although I did notice another dude bouncing around trying to make it known that he'd appreciate it as well.

Basically, the beauty of having this (from what I can gather from the FS page, here) is that it would allow you to change the volume without having the backlight activated. I waste a ton of juice doing this when I'm getting on and off the bus/metro or want to talk to someone and (rudely) not take out my earphones.

Anyway, just a thought, would be nice, thank you, etc, etc.

Rock on?
Reply With Quote

Advertisement [Remove Advertisement]

  #2  
Old 10-31-2007, 05:48 PM
kugel's Avatar
kugel kugel is offline
Rockbox Developer
 
Join Date: Dec 2006
Location: Berlin, Germany
Posts: 1,153
Default

I see no reason to include a rejected patch, though I don't understand why it was closed.
__________________
;;
Reply With Quote

  #3  
Old 10-31-2007, 05:57 PM
bacon_fat bacon_fat is offline
Junior Member
 
Join Date: Oct 2007
Posts: 11
Default

Strike one.

(But isn't including rejected ideas the reason people build their own in the first place? Feel very free to ignore this question as it might derail the thread completely).
Reply With Quote

  #4  
Old 10-31-2007, 06:18 PM
rtech rtech is offline
Member
 
Join Date: Jan 2007
Posts: 176
Default

That feature sounds like a good one, to me. Wonder why it was rejected... Is this: http://www.rockbox.org/tracker/task/6104, the same idea?
Reply With Quote

  #5  
Old 10-31-2007, 07:04 PM
kugel's Avatar
kugel kugel is offline
Rockbox Developer
 
Join Date: Dec 2006
Location: Berlin, Germany
Posts: 1,153
Default

Feel free to request reopening the patch.
__________________
;;
Reply With Quote

  #6  
Old 11-02-2007, 02:11 PM
Llorean Llorean is offline
Rockbox Developer
 
Join Date: Dec 2006
Posts: 397
Default

Patches get rejected once it's certain they're not going to be included in the official build.
Not every patch can be, in fact most can't. There's not unlimited room, and a patch has to be weighed in usefulness vs complexity. In the end, that patch really isn't that useful.

The few seconds the backlight comes on when you adjust volume isn't going to kill your battery, so there's not a very practical reason to include it.
Reply With Quote

Reply

Thread Tools Search this Thread
Search this Thread:

Advanced Search
Display Modes

Posting Rules
You may not post new threads
You may not post replies
You may not post attachments
You may not edit your posts

BB code is On
Smilies are On
[IMG] code is On
HTML code is Off

Forum Jump



All times are GMT -5. The time now is 11:11 AM.